Skip to content

Fix data race in Schema Engine #17921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshit-gangal merged 3 commits into from
Mar 10, 2025
+11 −7
Merged

Fix data race in Schema Engine #17921

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
287a36d
fix: data race on accessing Serving Primary check in schema engine
harshit-gangal Mar 6, 2025
c45fec9
Trigger Build
harshit-gangal Mar 6, 2025
4953597
fix: race by calling reload method that takes lock on the ticker, rev…
harshit-gangal Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion go/vt/vttablet/tabletserver/schema/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,13 @@ func (se *Engine) MakePrimary(serving bool) {
se.isServingPrimary = serving
}

// IsServingPrimary returns true if the tablet is currently serving as primary.
func (se *Engine) IsServingPrimary() bool {
se.mu.Lock()
defer se.mu.Unlock()
return se.isServingPrimary
}

// EnableHistorian forces tracking to be on or off.
// Only used for testing.
func (se *Engine) EnableHistorian(enabled bool) error {
Expand Down Expand Up @@ -477,7 +484,7 @@ func (se *Engine) reload(ctx context.Context, includeStats bool) error {
}

// On the primary tablet, we also check the data we have stored in our schema tables to see what all needs reloading.
shouldUseDatabase := se.isServingPrimary && se.schemaCopy
shouldUseDatabase := se.IsServingPrimary() && se.schemaCopy

// changedViews are the views that have changed. We can't use the same createTime logic for views because, MySQL
// doesn't update the create_time field for views when they are altered. This is annoying, but something we have to work around.
Expand Down