Fix data race in Schema Engine #17921
Merged
harshit-gangal merged 3 commits intovitessio:mainfrom Mar 10, 2025
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
systay
approved these changes
Mar 6, 2025
systay
approved these changes
Mar 6, 2025
frouioui
approved these changes
Mar 6, 2025
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…erts changes made in vitessio#17914 Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17921 +/- ##
=======================================
Coverage 67.56% 67.56%
=======================================
Files 1597 1597
Lines 259775 259782 +7
=======================================
+ Hits 175509 175528 +19
+ Misses 84266 84254 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the data race seen in schema engine.
This was caused by making changes in the PR #17855 which does not take lock on calling the
reloadmethod causing multiple data race.This also reverts a change made in PR to fix partial data race #17914
Related Issue(s)
Checklist
Deployment Notes