Skip to content

Fix data race in Schema Engine #17921

Merged
harshit-gangal merged 3 commits intovitessio:mainfrom
planetscale:se-race-fix
Mar 10, 2025
Merged

Fix data race in Schema Engine #17921
harshit-gangal merged 3 commits intovitessio:mainfrom
planetscale:se-race-fix

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal commented Mar 6, 2025

Description

This PR fixes the data race seen in schema engine.
This was caused by making changes in the PR #17855 which does not take lock on calling the reload method causing multiple data race.

This also reverts a change made in PR to fix partial data race #17914

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Mar 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 6, 2025
@harshit-gangal harshit-gangal added Type: Bug Component: VTTablet and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 6, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 6, 2025
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…erts changes made in vitessio#17914

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title Fix race condition in Schema Engine when accessing IsServingPrimary Fix data race in Schema Engine Mar 6, 2025
@harshit-gangal harshit-gangal requested review from GuptaManan100 and removed request for timvaillancourt March 6, 2025 17:28
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (74d9949) to head (4953597).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17921   +/-   ##
=======================================
  Coverage   67.56%   67.56%           
=======================================
  Files        1597     1597           
  Lines      259775   259782    +7     
=======================================
+ Hits       175509   175528   +19     
+ Misses      84266    84254   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harshit-gangal harshit-gangal merged commit a3a52c0 into vitessio:main Mar 10, 2025
105 checks passed
@harshit-gangal harshit-gangal deleted the se-race-fix branch March 10, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants