Skip to content

Use vtbackup in scheduled backups#17869

Merged
frouioui merged 2 commits intovitessio:mainfrom
planetscale:use-vtbackup-in-scheduled-backups
Mar 6, 2025
Merged

Use vtbackup in scheduled backups#17869
frouioui merged 2 commits intovitessio:mainfrom
planetscale:use-vtbackup-in-scheduled-backups

Conversation

@frouioui
Copy link
Copy Markdown
Member

This Pull Request brings the changes made in planetscale/vitess-operator#658 to the Vitess' examples. The operator manifest has changed with the new CRD definition, and the 101 through 306 steps now include a backup location.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Feb 25, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 25, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 25, 2025
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Examples Component: Operator Vtop related issues and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 25, 2025
@frouioui frouioui requested a review from deepthi February 25, 2025 22:20
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.57%. Comparing base (cfd4d29) to head (7f54af0).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17869      +/-   ##
==========================================
+ Coverage   67.46%   67.57%   +0.10%     
==========================================
  Files        1594     1597       +3     
  Lines      258984   259780     +796     
==========================================
+ Hits       174717   175535     +818     
+ Misses      84267    84245      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frouioui frouioui merged commit 97d7cf4 into vitessio:main Mar 6, 2025
103 checks passed
@frouioui frouioui deleted the use-vtbackup-in-scheduled-backups branch March 6, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Examples Component: Operator Vtop related issues Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants