add enableReloadSchema flag to ExecuteFetchAsDba in tabletmanager#658
Merged
yaoshengzhe merged 1 commit intovitessio:masterfrom May 4, 2015
yaoshengzhe:fix_add_reload_schema_flag
Merged
add enableReloadSchema flag to ExecuteFetchAsDba in tabletmanager#658yaoshengzhe merged 1 commit intovitessio:masterfrom yaoshengzhe:fix_add_reload_schema_flag
yaoshengzhe merged 1 commit intovitessio:masterfrom
yaoshengzhe:fix_add_reload_schema_flag
Conversation
go/vt/wrangler/schema.go
Outdated
Contributor
There was a problem hiding this comment.
We could pass in the boolean to applySqlShard, and in the for loop above, change code to:
for i, sqlLine := range createSql {
err = wr.applySqlShard(ctx, tabletInfo, sqlLine, i == len(createSql)-1)
So we only reload schema for the last one?
(if there is an error, we're in trouble anyway, not having reloaded the schema is the last of our worries)
Contributor
|
OK I'll be a pain for the rest of the variables too, they're all named enableReloadSchema, should be just reloadSchema everywhere. Last nit pick, I swear. :) |
reloadSchema is false by default. If it is set to be true, ExecuteFetchAsDba will reload tablet schema once it finishes successfully. In addition, this change also make CopySchemaShard trigger schema reload.
Contributor
Author
|
Done. Rename variable to reloadSchema. |
Contributor
|
LGTM |
yaoshengzhe
added a commit
that referenced
this pull request
May 4, 2015
add enableReloadSchema flag to ExecuteFetchAsDba in tabletmanager
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
maksimov
pushed a commit
to maksimov/vitess
that referenced
this pull request
Feb 19, 2026
…pting bind variables in time related function calls (vitessio#590)" (vitessio#658) This reverts commit 3f20a9d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reloadSchema is false by default. If it is set to be true, ExecuteFetchAsDba
will reload tablet schema once it finishes successfully. In addition, this change
also make CopySchemaShard trigger schema reload.