Skip to content

Update golangci-lint to newer faster version#16636

Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:golangci-lint
Aug 22, 2024
Merged

Update golangci-lint to newer faster version#16636
GuptaManan100 merged 1 commit intovitessio:mainfrom
planetscale:golangci-lint

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Aug 22, 2024

Description

We’ve recently updated to golangci-lint v1.60.1, but it was found to be a slower release. This PR upgrades the version to v1.60.2, which offers improved performance.

Additionally, this PR enhances the git hook to ensure that golangci-lint is updated only if the installed version is older than the required version. This prevents unnecessary downgrades and ensures that the tool is always up-to-date with the specified or newer version.

Related Issue(s)

#16599

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 22, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 22, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 22, 2024
@GuptaManan100 GuptaManan100 merged commit 3f87ca2 into vitessio:main Aug 22, 2024
@GuptaManan100 GuptaManan100 deleted the golangci-lint branch August 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants