Update Golang to 1.23.0

[frouioui]

Description

This PR bumps the golang version used on main to go1.23.0 following their latest release made yesterday.

[vitess-bot]

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[frouioui]

The downgrade tests have been changed to use go1.22.6 instead of go1.23.0 since there is an incompatibility between these two versions (https://tip.golang.org/doc/go1.23#linker)

[codecov]

Codecov Report

Attention: Patch coverage is 32.30769% with 132 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (fae7540) to head (693ee5f).
Report is 7 commits behind head on main.

Files	Patch %	Lines
go/mysql/query.go	5.71%	33 Missing ⚠️
go/mysql/client.go	16.66%	30 Missing ⚠️
go/vt/vtgate/evalengine/fn_regexp.go	11.11%	16 Missing ⚠️
go/vt/vtctl/vtctl.go	0.00%	11 Missing ⚠️
go/mysql/auth_server.go	0.00%	5 Missing ⚠️
go/mysql/auth_server_static.go	42.85%	4 Missing ⚠️
go/mysql/replication.go	66.66%	4 Missing ⚠️
go/mysql/vault/auth_server_vault.go	0.00%	3 Missing ⚠️
go/vt/vtorc/inst/instance_dao.go	50.00%	3 Missing ⚠️
go/mysql/conn.go	50.00%	2 Missing ⚠️
... and 17 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16599      +/-   ##
==========================================
+ Coverage   68.87%   68.89%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      200624   200621       -3     
==========================================
+ Hits       138179   138216      +37     
+ Misses      62445    62405      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deepthi]

We'll need to fix golangci-lint as well. It failed the only time it ran on this PR.
https://github.com/vitessio/vitess/actions/runs/10394154257/job/28783312147

[systay]

should this not be 1.23.0?

[frouioui]

Fixed in #16625

[guywithnose]

Are there plans to cut a new release tag soon that would include this change?