Skip to content

Enable 'heartbeat_on_demand_duration' in local/examples#15204

Merged
shlomi-noach merged 1 commit intovitessio:mainfrom
planetscale:examples-heartbeat-on-demand
Feb 20, 2024
Merged

Enable 'heartbeat_on_demand_duration' in local/examples#15204
shlomi-noach merged 1 commit intovitessio:mainfrom
planetscale:examples-heartbeat-on-demand

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach commented Feb 12, 2024

Description

Followup to #14978, #14980, and #15099. This PR re-enables heartbeat_on_demand_duration in vttablet-up.sh script in examples/local.

This comes at no cost when the throttler is disabled, and makes it possible for the throttler to work based on replication lag.

Future work to change the defaults/default behavior of heartbeat mechanism. See discussion in #15099.

Without this PR, the throttler won't work properly in examples. I therefore want to backport this to all supported versions, just as #14980 was backported.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Feb 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 12, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 12, 2024
@shlomi-noach shlomi-noach requested a review from a team February 12, 2024 08:39
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsWebsiteDocsUpdate What it says labels Feb 12, 2024
@deepthi deepthi removed the NeedsIssue A linked issue is missing for this Pull Request label Feb 20, 2024
@shlomi-noach shlomi-noach merged commit f1a95e1 into vitessio:main Feb 20, 2024
@shlomi-noach shlomi-noach deleted the examples-heartbeat-on-demand branch February 20, 2024 05:48
vitess-bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitess-bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitess-bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Feb 20, 2024
#15204) (#15291)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Feb 20, 2024
#15204) (#15290)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Feb 20, 2024
#15204) (#15292)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants