Enable 'heartbeat_on_demand_duration' in local/examples#15204
Merged
shlomi-noach merged 1 commit intovitessio:mainfrom Feb 20, 2024
Merged
Enable 'heartbeat_on_demand_duration' in local/examples#15204shlomi-noach merged 1 commit intovitessio:mainfrom
shlomi-noach merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
This was referenced Feb 12, 2024
mattlord
approved these changes
Feb 12, 2024
deepthi
approved these changes
Feb 20, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitess-bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitess-bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #14978, #14980, and #15099. This PR re-enables
heartbeat_on_demand_durationinvttablet-up.shscript inexamples/local.This comes at no cost when the throttler is disabled, and makes it possible for the throttler to work based on replication lag.
Future work to change the defaults/default behavior of heartbeat mechanism. See discussion in #15099.
Without this PR, the throttler won't work properly in
examples. I therefore want to backport this to all supported versions, just as #14980 was backported.Related Issue(s)
Checklist
Deployment Notes