Skip to content

examples: rm heartbeat flags#14980

Merged
frouioui merged 1 commit intovitessio:mainfrom
planetscale:maxeng-localexample-rm-heartbeat
Jan 19, 2024
Merged

examples: rm heartbeat flags#14980
frouioui merged 1 commit intovitessio:mainfrom
planetscale:maxeng-localexample-rm-heartbeat

Conversation

@maxenglander
Copy link
Copy Markdown
Collaborator

@maxenglander maxenglander commented Jan 18, 2024 •
edited by mattlord
Loading

Description

I chatted w/ @mattlord about #14978, he said:

We should just remove that flag in the examples.

I initially added those flags here as I was using the local examples to test it: #12737

They shouldn’t be necessary anymore — you can enable the throttler at the keyspace level in the topo using vtctldclient and use defaults for the other things.

We should backport all the way to release-17.0 as well. That’s the oldest version that has those flags in the script.

I tested this by running all the way through the local example, verifying that no lag was reported on @replica or @rdonly, and did not see any other issues.

Related Issue(s)

Fixes #14978.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@maxenglander
examples: rm heartbeat flags
abe0a11 
Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander self-assigned this Jan 18, 2024
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jan 18, 2024 •
edited by mattlord
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 18, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 18, 2024
@maxenglander maxenglander marked this pull request as ready for review January 18, 2024 04:31
@maxenglander maxenglander requested a review from deepthi as a code owner January 18, 2024 04:31
@mattlord mattlord added Type: Documentation and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 18, 2024
mattlord
mattlord approved these changes Jan 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxenglander ! ❤️

@shlomi-noach can you also please take a quick look at this when you have time? Thanks!

@frouioui frouioui merged commit 22809e4 into vitessio:main Jan 19, 2024
@frouioui frouioui deleted the maxeng-localexample-rm-heartbeat branch January 19, 2024 20:17
@vitess-bot vitess-bot bot mentioned this pull request Jan 19, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Jan 19, 2024
@vitess-bot
examples: rm heartbeat flags (#14980)
065f301 
Signed-off-by: Max Englander <max@planetscale.com>
@vitess-bot vitess-bot bot mentioned this pull request Jan 19, 2024
Merged
@frouioui
Copy link
Copy Markdown
Member

frouioui commented Jan 19, 2024

Ah, sorry, I merged this after reading @shlomi-noach can you also please take a quick look at this when you have time? Thanks!.

@shlomi-noach, feel free to revert this PR if it does not look good.

mattlord added a commit that referenced this pull request Jan 19, 2024
@vitess-bot @mattlord
[release-17.0] examples: rm heartbeat flags (#14980) (#14998)
82be9db 
Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
mattlord pushed a commit that referenced this pull request Jan 19, 2024
@vitess-bot
[release-18.0] examples: rm heartbeat flags (#14980) (#14999)
fdc8d1b 
Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor

shlomi-noach commented Jan 21, 2024

It's fine to remove these flags in examples as well as backporting to 17 👍

@shlomi-noach shlomi-noach mentioned this pull request Jan 31, 2024
Closed
5 tasks
@shlomi-noach
Copy link
Copy Markdown
Contributor

shlomi-noach commented Jan 31, 2024

Followup in #15099

@shlomi-noach shlomi-noach mentioned this pull request Feb 12, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@frouioui frouioui frouioui approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@deepthi deepthi Awaiting requested review from deepthi

Assignees

@maxenglander maxenglander

Labels

Component: Examples Component: Throttler Type: Bug

Projects

None yet

Milestone

v19.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: Vitess local examples high replica heartbeat lag

4 participants

@maxenglander @frouioui @shlomi-noach @mattlord