Skip to content

TestStreamMigrateMainflow: fix panic in test #14420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 1 commit into from
Nov 1, 2023
Merged

TestStreamMigrateMainflow: fix panic in test #14420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion go/vt/wrangler/fake_tablet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ import (
"testing"
"time"

vdiff2 "vitess.io/vitess/go/vt/vttablet/tabletmanager/vdiff"

@dbussink dbussink Nov 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this alias?

@rohit-nayak-ps rohit-nayak-ps Nov 1, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a type vdiff defined in wrangler

"vitess.io/vitess/go/vt/vttablet/tabletserver/tabletenv"

"github.com/stretchr/testify/require"
"google.golang.org/grpc"

Expand Down Expand Up @@ -187,7 +190,7 @@ func (ft *fakeTablet) StartActionLoop(t *testing.T, wr *Wrangler) {
ft.Tablet.PortMap["vt"] = vtPort
ft.Tablet.PortMap["grpc"] = gRPCPort
ft.Tablet.Hostname = "127.0.0.1"

config := &tabletenv.TabletConfig{}
// Create a test tm on that port, and re-read the record
// (it has new ports and IP).
ft.TM = &tabletmanager.TabletManager{
Expand All @@ -196,6 +199,7 @@ func (ft *fakeTablet) StartActionLoop(t *testing.T, wr *Wrangler) {
MysqlDaemon: ft.FakeMysqlDaemon,
DBConfigs: &dbconfigs.DBConfigs{},
QueryServiceControl: tabletservermock.NewController(),
VDiffEngine: vdiff2.NewEngine(config, wr.TopoServer(), ft.Tablet),
}
if err := ft.TM.Start(ft.Tablet, 0); err != nil {
t.Fatal(err)
Expand Down