TestStreamMigrateMainflow: fix panic in test#14420
Merged
rohit-nayak-ps merged 1 commit intovitessio:mainfrom Nov 1, 2023
Merged
TestStreamMigrateMainflow: fix panic in test#14420rohit-nayak-ps merged 1 commit intovitessio:mainfrom
rohit-nayak-ps merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
mattlord
approved these changes
Nov 1, 2023
dbussink
reviewed
Nov 1, 2023
| "testing" | ||
| "time" | ||
|
|
||
| vdiff2 "vitess.io/vitess/go/vt/vttablet/tabletmanager/vdiff" |
Member
Author
There was a problem hiding this comment.
There is a type vdiff defined in wrangler
deepthi
approved these changes
Nov 1, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test environment was not being properly initialized resulting in panics related to vdiff goroutines. This was not relevant to the test and not failing the tests, but the panics were being logged.
Related Issue(s)
Checklist
Deployment Notes