Skip --config-file-not-found-handling in upgrade downgrade tests when vttablet < 17.x.x

[frouioui]

Description

Saw in #13268 that the [Upgrade Downgrade Test - Backups - Manual](https://github.com/vitessio/vitess/actions/runs/5204734892/jobs/9402321444?pr=13268#logs) test was failing due to an invalid flag when running with vttablet:16.0.2 from the release-17.0 branch. The incorrect flag is: --config-file-not-found-handling.

This PR ensures we do not add the flag if the version of vttablet is not greater or equal to 17.

Log fragment from previous CI run:

unknown flag: --config-file-not-found-handling

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[deepthi]

This doesn't seem right to me. The v16 version of vttablet should not have this flag regardless. How can code that is only in v17 get into a v16 binary version of vttablet?

[deepthi]

This doesn't seem right to me. The v16 version of vttablet should not have this flag regardless. How can code that is only in v17 get into a v16 binary version of vttablet?

To put it another way, this PR is changing production code to check the version before adding a flag. The flag should not exist on the release-16.0 branch already, so this is the wrong change. The right way is to fix is to change whatever test code is providing the flag to check the binary version and not provide the flag.

[frouioui]

This doesn't seem right to me. The v16 version of vttablet should not have this flag regardless. How can code that is only in v17 get into a v16 binary version of vttablet?

To put it another way, this PR is changing production code to check the version before adding a flag. The flag should not exist on the release-16.0 branch already, so this is the wrong change. The right way is to fix is to change whatever test code is providing the flag to check the binary version and not provide the flag.

Yes, I've got that thanks! Not sure why I steered this way, I have a proper fix coming up.

[mattlord]

I have a suggestion for a simpler and more robust command. But I will approve so that you can resolve that and merge when ready. Thanks!