Skip to content

[release-17.0] Remove viper warnings from local examples (#13234)#13268

Merged
frouioui merged 3 commits intorelease-17.0from
backport-13234-to-release-17.0
Jun 12, 2023
Merged

[release-17.0] Remove viper warnings from local examples (#13234)#13268
frouioui merged 3 commits intorelease-17.0from
backport-13234-to-release-17.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 7, 2023

Description

This is a backport of #13234.

… flag to all binaries in local examples

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot bot added Backport This is a backport Component: Examples Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature) NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 7, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 7, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Jun 7, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 8, 2023
@frouioui frouioui modified the milestones: v17.0.0, v18.0.0 Jun 12, 2023
@frouioui frouioui merged commit 22995b4 into release-17.0 Jun 12, 2023
@frouioui frouioui deleted the backport-13234-to-release-17.0 branch June 12, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Examples Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants