Skip to content

Temporarily disable panic in mysqld when socket files are directly used #13198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 3 commits into from
Jun 1, 2023
Merged

Temporarily disable panic in mysqld when socket files are directly used #13198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbdb00f
Temporarily disable panic until we fix an issue with ApplySchema: oth…
rohit-nayak-ps May 30, 2023
b60bd92
Add reference to issue
rohit-nayak-ps May 31, 2023
03c4323
Address review comment
rohit-nayak-ps May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion go/vt/mysqlctl/mysqld.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,10 @@ func (mysqld *Mysqld) ApplyBinlogFile(ctx context.Context, binlogFile string, re
// remote through mysqlctl.
func noSocketFile() {
if socketFile != "" {
panic("Running remotely through mysqlctl, socketFile must not be set")
// We log an error for now until we fix the issue with ApplySchema surfacing in MoveTables.
// See https://github.com/vitessio/vitess/issues/13203 and https://github.com/vitessio/vitess/pull/13178
//panic("Running remotely through mysqlctl, socketFile must not be set")
log.Warning("Running remotely through mysqlctl and thus socketFile should not be set")
}
}

Expand Down