Temporarily disable panic in mysqld when socket files are directly used#13198
Merged
rohit-nayak-ps merged 3 commits intovitessio:mainfrom Jun 1, 2023
Merged
Conversation
…erwise some VReplication Workflows are crasing vttablets Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Collaborator
|
Let's create an issue so that we can track both the temporary fix and permanent fix using it. |
deepthi
reviewed
May 30, 2023
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
mattlord
approved these changes
May 31, 2023
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
shlomi-noach
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change in #13123 will cause
MoveTablesworkflows to panic in certain cases because they use the mysql CLI directly to create the schema of new tables on the target.The real fix is at #13178. However that has exposed a race where vttablets don't always find the newly created tables. To move forward with the v17 RC1 release we comment out the panic until we find a proper solution for this.
Related Issue(s)
Temporary fix for #13203
Also:
#13123
#13178
Checklist