Skip TestReparentDoesntHangIfPrimaryFails in vttablet v16 and above#12387
Merged
frouioui merged 1 commit intovitessio:release-15.0from Feb 27, 2023
Merged
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Contributor
GuptaManan100
left a comment
There was a problem hiding this comment.
Why is this required?
GuptaManan100
approved these changes
Feb 27, 2023
Contributor
GuptaManan100
left a comment
There was a problem hiding this comment.
Nevermind, I just read the description
dbussink
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up of the recent work done by @rohit-nayak-ps around vttablet sidecar (#11520). In the latter work, we removed
Create/AlterReparentJournal, this PR fixes a test that uses this SQL query. The test will not be ran during upgrade tests when vttablet is on version 16.Related Issue(s)
Checklist
Deployment Notes