Skip to content

Upgrade to go1.18.9#11897

Merged
frouioui merged 6 commits intovitessio:release-15.0from
planetscale:upgrade-15-to-go1.19.4
Dec 9, 2022
Merged

Upgrade to go1.18.9#11897
frouioui merged 6 commits intovitessio:release-15.0from
planetscale:upgrade-15-to-go1.19.4

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Dec 7, 2022

Description

This Pull Request upgrades the go version used on release-15.0 to go1.18.9.

Bumps the bootstrap version to 11.2

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base go labels Dec 7, 2022
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Dec 7, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui changed the title upgrade to go1.19.4 Upgrade to go1.19.4 Dec 7, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do major golang version upgrades on release branches. We should only be doing security patch upgrades.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui changed the title Upgrade to go1.19.4 Upgrade to go1.18.9 Dec 8, 2022
@frouioui frouioui requested a review from deepthi December 8, 2022 10:08
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@rsajwani
Copy link
Copy Markdown
Contributor

rsajwani commented Dec 9, 2022

does go upgrade always result in upgrade in bootstrap version or is it just you did both as part of same PR to save CI cycle.?
Rest looks good to me.
Also its would be good if you can mention bootstrap version upgrade in description as well.

Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for after answering Rameez's comment.

@frouioui
Copy link
Copy Markdown
Member Author

frouioui commented Dec 9, 2022

does go upgrade always result in upgrade in bootstrap version or is it just you did both as part of same PR to save CI cycle.?
Rest looks good to me.
Also its would be good if you can mention bootstrap version upgrade in description as well.

Hello @rsajwani, we always bump the bootstrap version when upgrading the Go version. When we upgrade the Go version on a release branch, we bump the bootstrap version by 0.1. On main, we bump the version by 1.0.

@frouioui frouioui merged commit c4d606f into vitessio:release-15.0 Dec 9, 2022
@frouioui frouioui deleted the upgrade-15-to-go1.19.4 branch December 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants