Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
left a comment
There was a problem hiding this comment.
We should not do major golang version upgrades on release branches. We should only be doing security patch upgrades.
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
|
does go upgrade always result in upgrade in bootstrap version or is it just you did both as part of same PR to save CI cycle.? |
GuptaManan100
left a comment
There was a problem hiding this comment.
Approval for after answering Rameez's comment.
Hello @rsajwani, we always bump the bootstrap version when upgrading the Go version. When we upgrade the Go version on a release branch, we bump the bootstrap version by |
Description
This Pull Request upgrades the go version used on
release-15.0togo1.18.9.Bumps the bootstrap version to
11.2