Skip to content

updating summary and release notes for v15.0.1#11852

Merged
frouioui merged 2 commits intovitessio:mainfrom
planetscale:summary-update-v15.0.1
Nov 30, 2022
Merged

updating summary and release notes for v15.0.1#11852
frouioui merged 2 commits intovitessio:mainfrom
planetscale:summary-update-v15.0.1

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

@rsajwani rsajwani commented Nov 30, 2022 •
edited
Loading

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

We realized we should mentioned about vtadmin issue (#11679) in our summary and release notes explicitly. Therefore updating them with the issue.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rsajwani
updating summary and release notes for v15.0.1
78e700b 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 30, 2022 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani self-assigned this Nov 30, 2022
frouioui
frouioui reviewed Nov 30, 2022
View reviewed changes
frouioui
frouioui reviewed Nov 30, 2022
View reviewed changes
frouioui
frouioui reviewed Nov 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@rsajwani
fixing typos
38de46e 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@frouioui frouioui merged commit e9baa1c into vitessio:main Nov 30, 2022
@frouioui frouioui deleted the summary-update-v15.0.1 branch November 30, 2022 08:16
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 30, 2022
@rsajwani @frouioui
updating summary and release notes for v15.0.1 (vitessio#11852)
6362b9b 
* updating summary and release notes for v15.0.1

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typos

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@frouioui frouioui mentioned this pull request Nov 30, 2022
Merged
frouioui added a commit that referenced this pull request Nov 30, 2022
@frouioui @rsajwani
updating summary and release notes for v15.0.1 (#11852) (#11860)
9f4925d 
* updating summary and release notes for v15.0.1

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typos

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@JiriCtvrtka JiriCtvrtka mentioned this pull request Dec 20, 2022
Merged
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rsajwani rsajwani

Labels

Component: Deployments Component: General Changes throughout the code base Type: Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsajwani @frouioui @GuptaManan100