Skip to content

Back to dev mode after v15.0.1#11848

Merged
mattlord merged 1 commit intovitessio:release-15.0from
planetscale:release-15.0-back-to-dev-3
Nov 29, 2022
Merged

Back to dev mode after v15.0.1#11848
mattlord merged 1 commit intovitessio:release-15.0from
planetscale:release-15.0-back-to-dev-3

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

Includes the changes required to go back into dev mode (v15.0.2-SNAPSHOT) after the release of v15.0.1.

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 29, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Nov 29, 2022
@mattlord mattlord merged commit 14d3106 into vitessio:release-15.0 Nov 29, 2022
@mattlord mattlord deleted the release-15.0-back-to-dev-3 branch November 29, 2022 22:28
set -ex

vt_base_version='v15.0.1'
vt_base_version='15.0.2-SNAPSHOT'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frouioui I believe this needs to be v15.0.2. Can you either confirm, or tell me why the format has been changed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants