Skip to content

Fix deprecated usage of set-output#11844

Merged
deepthi merged 1 commit intovitessio:mainfrom
planetscale:dbussink/fix-deprecated-set-output
Nov 30, 2022
Merged

Fix deprecated usage of set-output#11844
deepthi merged 1 commit intovitessio:mainfrom
planetscale:dbussink/fix-deprecated-set-output

Conversation

@dbussink
Copy link
Copy Markdown
Member

The set-output command is deprecated and will break in the future. This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Also marking this for back port so we don't use it on supported releases either once this is really removed.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frouioui
Copy link
Copy Markdown
Member

CI is failing with the following error: next_release_ref=${$next_release_ref}: bad substitution, I think we can get rid of the inner $ right?

The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/fix-deprecated-set-output branch from aa82af3 to 1d7b3dd Compare November 29, 2022 13:37
@dbussink
Copy link
Copy Markdown
Member Author

CI is failing with the following error: next_release_ref=${$next_release_ref}: bad substitution, I think we can get rid of the inner $ right?

Yeah, already saw that and fixed it up. Bad copy paste 😞

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Nov 30, 2022

We also need to back port to release-14.0 because that is under maintenance until June 27, 2023. Added the label.

@deepthi deepthi merged commit 0f30178 into vitessio:main Nov 30, 2022
@deepthi deepthi deleted the dbussink/fix-deprecated-set-output branch November 30, 2022 01:11
dbussink added a commit to planetscale/vitess that referenced this pull request Nov 30, 2022
The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
frouioui pushed a commit that referenced this pull request Nov 30, 2022
The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink added a commit to planetscale/vitess that referenced this pull request Dec 1, 2022
The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Also upgrades some more runners to Ubuntu 20.04 that were missed in
previous backports.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
frouioui pushed a commit that referenced this pull request Dec 6, 2022
* Fix deprecated usage of set-output (#11844) (#11855)

The `set-output` command is deprecated and will break in the future.
This moves to the new style for all our GitHub Actions.

See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Also upgrades some more runners to Ubuntu 20.04 that were missed in
previous backports.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* Upgrade to Ubuntu 20.04 for endtoend tests (#11113)

This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default)
just for the end to end tests and updates the associated tests.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants