refactoring: Horizon planning on the operators#11698
Closed
systay wants to merge 4 commits intovitessio:mainfrom
Closed
refactoring: Horizon planning on the operators#11698systay wants to merge 4 commits intovitessio:mainfrom
systay wants to merge 4 commits intovitessio:mainfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
requested review from
GuptaManan100,
frouioui and
harshit-gangal
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Andres Taylor <andres@planetscale.com>
Comment on lines
+121
to
+136
| r := newRoute( | ||
| &Update{ | ||
| QTable: qt, | ||
| VTable: vindexTable, | ||
| Assignments: assignments, | ||
| ChangedVindexValues: cvv, | ||
| OwnedVindexQuery: ovq, | ||
| AST: updStmt, | ||
| }, | ||
| RouteOpCode: opCode, | ||
| Keyspace: vindexTable.Keyspace, | ||
| VindexPreds: vp, | ||
| TargetDestination: dest, | ||
| } | ||
| opCode, | ||
| vindexTable.Keyspace, | ||
| dest, | ||
| vp, | ||
| nil, | ||
| nil, | ||
| ) |
Member
There was a problem hiding this comment.
Not a blocker at all, but just my personal opinion: It's quite unfortunate go does not support named arguments. The previous version that build the struct directly was much more readable, as you could see what the individual struct members were set to, where as now newRoute takes a bunch of values but it's not obvious what they mean (e.g. those two nil arguments at the end).
3 tasks
Contributor
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
github-actions
bot
added
the
Stale
Contributor
|
This PR was closed because it has been stale for 7 days with no activity. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes