Horizon planning on operators#12506
Merged
frouioui merged 2 commits intovitessio:mainfrom Mar 22, 2023
Merged
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
vitess-bot
bot
added
NeedsDescriptionUpdate
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
systay
force-pushed
the
horizon-planning-on-operators
branch
from
5789768 to
eda6c6f
Compare
frouioui
added
Type: Enhancement
frouioui
requested review from
GuptaManan100,
arthurschreiber,
harshit-gangal and
systay
as code owners
systay
approved these changes
Mar 15, 2023
Member
Author
|
Upgrade Downgrade test failures can safely be ignored here. They're due to this branch being old and not on |
harshit-gangal
approved these changes
Mar 20, 2023
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
Looks good. Comments can be added for readability.
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
horizon-planning-on-operators
branch
from
96f5fe1 to
35d53e4
Compare
Comment on lines
+67
to
+69
| canShortcut := isRoute && sel.Having == nil && !needsOrdering | ||
|
|
||
| // If we still have a HAVING clause, it's because it could not be pushed to the WHERE, | ||
| // so it probably has aggregations | ||
| switch { | ||
| case qp.NeedsAggregation() || sel.Having != nil: | ||
| return nil, rewrite.VisitChildren, errNotHorizonPlanned | ||
| case canShortcut && !needsOrdering && !qp.NeedsDistinct() && in.Select.GetLimit() == nil: | ||
| if !qp.NeedsAggregation() && sel.Having == nil && canShortcut && !needsOrdering && !qp.NeedsDistinct() && in.Select.GetLimit() == nil { |
Member
There was a problem hiding this comment.
canShortcut is only used in the if condition which can be expanded as it will only add isRoute check rest of the checks are already present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves more of the horizon planning to the operators.
Related Issue(s)
#11626
Checklist
Deployment Notes