Skip to content

update jsonparser dependency#11694

Merged
deepthi merged 2 commits intovitessio:mainfrom
planetscale:ds-json-dep
Nov 11, 2022
Merged

update jsonparser dependency#11694
deepthi merged 2 commits intovitessio:mainfrom
planetscale:ds-json-dep

Conversation

@deepthi
Copy link
Collaborator

@deepthi deepthi commented Nov 11, 2022 •
edited by rsajwani
Loading

Description

PR fixes

  1. Use a released version instead of random SHA
  2. Fixes typo in the pull request template

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@deepthi
update jsonparser dependency
65c6f71 
Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 11, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi
small change to PR template
415d883 
Signed-off-by: deepthi <deepthi@planetscale.com>
@rsajwani
Copy link
Contributor

rsajwani commented Nov 11, 2022

updated the description a bit

@deepthi deepthi merged commit 90fe6f4 into vitessio:main Nov 11, 2022
@deepthi deepthi deleted the ds-json-dep branch November 11, 2022 21:45
This was referenced Nov 11, 2022
Merged
Merged
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 11, 2022

I was unable to backport this Pull Request to the following branches: release-13.0.

deepthi added a commit that referenced this pull request Nov 13, 2022
@vitess-bot @deepthi
[release-15.0] update jsonparser dependency (#11694) (#11696)
e3b2ce5 
* update jsonparser dependency

Signed-off-by: deepthi <deepthi@planetscale.com>

* small change to PR template

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: deepthi <deepthi@planetscale.com>
deepthi added a commit that referenced this pull request Nov 13, 2022
@vitess-bot @deepthi
[release-14.0] update jsonparser dependency (#11694) (#11695)
36431d4 
* update jsonparser dependency

Signed-off-by: deepthi <deepthi@planetscale.com>

* small change to PR template

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: deepthi <deepthi@planetscale.com>
@dbussink dbussink mentioned this pull request Nov 16, 2022
Merged
3 tasks
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@dbussink
Cherry-pick jsonparser update (vitessio#11694) (vitessio#1323)
5349402 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsajwani rsajwani rsajwani approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

No one assigned

Labels

Component: VReplication dependencies Pull requests that update a dependency file Type: CI/Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepthi @rsajwani