Skip to content

Fix Vitess Operator example#11546

Merged
frouioui merged 1 commit intovitessio:release-15.0from
planetscale:vtop-exmample-fix
Oct 20, 2022
Merged

Fix Vitess Operator example#11546
frouioui merged 1 commit intovitessio:release-15.0from
planetscale:vtop-exmample-fix

Conversation

@GuptaManan100
Copy link
Contributor

Description

This PR fixes the Vitess operator example by updating the crds and the corresponding changes to the yaml files.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Examples Forwardport to: main This will forward port the PR to the main branch labels Oct 20, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 20, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui merged commit 6e1aab8 into vitessio:release-15.0 Oct 20, 2022
@frouioui frouioui deleted the vtop-exmample-fix branch October 20, 2022 13:02
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 20, 2022

I was unable to forwardport this Pull Request to the following branches: main.

GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Oct 20, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui pushed a commit that referenced this pull request Oct 20, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
@frouioui frouioui mentioned this pull request Oct 20, 2022
100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Examples Forwardport to: main This will forward port the PR to the main branch Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants