Skip to content

[backport] Backports #11512 to release-15.0#11528

Merged
deepthi merged 1 commit intovitessio:release-15.0from
planetscale:andrew/bp-11512
Oct 18, 2022
Merged

[backport] Backports #11512 to release-15.0#11528
deepthi merged 1 commit intovitessio:release-15.0from
planetscale:andrew/bp-11512

Conversation

@ajm188
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 commented Oct 18, 2022

Description

This is a back port of #11512

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

* Allow version to be accessible via the -v shorthand

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* update help text

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* fix nonidempotence for tests

Signed-off-by: Andrew Mason <andrew@planetscale.com>

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Backport This is a backport Component: CLI labels Oct 18, 2022
@ajm188 ajm188 added this to the v15.0 milestone Oct 18, 2022
@ajm188 ajm188 requested a review from deepthi as a code owner October 18, 2022 14:15
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 18, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: CLI Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants