Skip to content

Backport (15.0): Full Status tab improvements for VTAdmin#11483

Merged
deepthi merged 1 commit intovitessio:release-15.0from
planetscale:full-status-15
Oct 13, 2022
Merged

Backport (15.0): Full Status tab improvements for VTAdmin#11483
deepthi merged 1 commit intovitessio:release-15.0from
planetscale:full-status-15

Conversation

@GuptaManan100
Copy link
Contributor

Description

This is a backport for #11470.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

* feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings

Signed-off-by: Manan Gupta <manan@planetscale.com>

* refactor: prettify the changed file

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix replication state strings and simplify code

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface Backport This is a backport labels Oct 13, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 13, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi
Copy link
Collaborator

deepthi commented Oct 13, 2022

If I filter the Actions, I can see vtorc passed 16 hours ago
https://github.com/vitessio/vitess/actions/workflows/cluster_endtoend_vtorc.yml?query=branch%3Afull-status-15
Not sure why it still says Expected here, but overriding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants