Give all permissions in rbac in examples#11463
Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom Oct 11, 2022
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
ajm188
approved these changes
Oct 11, 2022
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
3 tasks
GuptaManan100
added a commit
that referenced
this pull request
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today while running the local example I noticed that we don't give all the permissions to the users when we run the local-examples. This leads to the user not being able to manage the tablets' replication from the vtadmin page. This is a little counter-intuitive and not easy to debug. For first time users of Vitess, all the vtadmin operations should work without any issues. Rbac is a more of advanced thing that is of more importance when going into production.
This PR fixes the examples to give all the users all the accesses available so that everything works without any issues.
Related Issue(s)
Checklist
Deployment Notes