Skip to content

Use JSON for plan tests#11430

Merged
systay merged 3 commits intovitessio:mainfrom
planetscale:better-tests
Oct 4, 2022
Merged

Use JSON for plan tests#11430
systay merged 3 commits intovitessio:mainfrom
planetscale:better-tests

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Oct 4, 2022

Description

Changes the plan-tests to use JSON instead of the complex format that was there before. This allows for better IDE support and less code parsing the text files.

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 4, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 49dfecb into vitessio:main Oct 4, 2022
@systay systay deleted the better-tests branch October 4, 2022 11:56
systay added a commit to planetscale/vitess that referenced this pull request Oct 4, 2022
* Use JSON for plan tests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move vschemas into single directory

Signed-off-by: Andres Taylor <andres@planetscale.com>

* indentation

Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
systay added a commit that referenced this pull request Oct 10, 2022
* Use JSON for plan tests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* move vschemas into single directory

Signed-off-by: Andres Taylor <andres@planetscale.com>

* indentation

Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants