Skip to content

For partial MoveTables, setup reverse shard routing rules on workflow creation#11415

Merged
mattlord merged 13 commits intovitessio:mainfrom
planetscale:shard_migration_pre_cutover_routing
Oct 5, 2022
Merged

For partial MoveTables, setup reverse shard routing rules on workflow creation#11415
mattlord merged 13 commits intovitessio:mainfrom
planetscale:shard_migration_pre_cutover_routing

Conversation

@mattlord
Copy link
Member

@mattlord mattlord commented Oct 1, 2022 •
edited
Loading

Description

For normal MoveTables operations — where you're moving tables from one keyspace to another, i.e. the move is at the keyspace level — global routing rules are put in place when the workflow is created so that any attempted access of those tables on the target keyspace are routed to the source keyspace. (In this scenario shard targeting is how you would explicitly get around this routing.)

For partial MoveTables operations, you're moving the tables from one keyspace to another one shard at a time — so the move is per shard rather than per keyspace. In this scenario you want all traffic to go to one side or the other for a given shard, including shard targeted queries. This then offers the same kind of "global" (scoped to a shard) routing at the shard level that you would expect when doing keyspace level MoveTables. This PR implements that functionality.

Note
We have NO documentation on partial MoveTables today (not even the relevant vttablet and vtgate flags). Should I create a new page in the docs here, or continue to defer that part?
Answer: YES. See: vitessio/website#1160

Related Issue(s)

Checklist

mattlord and others added 5 commits September 29, 2022 23:36
@mattlord
TEsting....
6bb231d 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@rohit-nayak-ps
Setup reverse routing rules at the start of the first partial movetab…
2e0e3bb 
…les. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Update display representation of state for partially moved keyspaces
7fb0ccf 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@mattlord
Test improvements
b56d1ca 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Cleanup shard routing rules on cancel/complete
dc1729d 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Oct 1, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 1, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord
Cleanup intermediate changes
618bdb5 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Merge remote-tracking branch 'origin/main' into shard_migration_pre_c…
01f2af7 
…utover_routing

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Fix DryRun TrafficSwitcher and its tests
fc2f8cd 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Support concurrent partial movetables for N keyspaces
a202f19 
And other minor changes after self review

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord marked this pull request as ready for review October 1, 2022 07:58
@mattlord mattlord requested review from aquarapid and removed request for deepthi October 1, 2022 07:58
@mattlord
Avoid unnecessary save + rebuild steps
1358948 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Add secondary ordering for shard routing rules on to_keyspace
673ead5 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Minor changes after self review
95bf400 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord changed the title For partial MoveTables, setup reverse shard routing rules on first workflow creation For partial MoveTables, setup reverse shard routing rules on workflow creation Oct 2, 2022
@deepthi
Copy link
Collaborator

deepthi commented Oct 3, 2022

We have NO documentation on partial MoveTables today (not even the relevant vttablet and vtgate flags). Should I create a new page in the docs here, or continue to defer that part?

I think we should document it. @rohit-nayak-ps thoughts?

@rohit-nayak-ps
Copy link
Member

rohit-nayak-ps commented Oct 4, 2022

I think we should document it. @rohit-nayak-ps thoughts?

Yes, that is the plan. We will have a link from MoveTables to a separate page highlighting the use cases, shard routing rules and their effect, limitations (need to disable schema tracking, for example) and the fact that it is experimental. Should be ready this week.

rohit-nayak-ps
rohit-nayak-ps approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattlord mattlord mentioned this pull request Oct 4, 2022
Merged
@mattlord
Copy link
Member Author

mattlord commented Oct 4, 2022 •
edited
Loading

Please note that this will be merged (and backported to release-15.0) just after the v15 RC1 release so that:

  1. We don't interfere with that timely release
  2. We have a feature complete shard level migration feature in 15.0 (see docs here: Document shard level migrations feature website#1160)

@rsajwani rsajwani mentioned this pull request Oct 4, 2022
Closed
100 tasks
@mattlord
Merge remote-tracking branch 'origin/main' into shard_migration_pre_c…
fa44bab 
…utover_routing

Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord added a commit that referenced this pull request Oct 6, 2022
@mattlord @rohit-nayak-ps
For partial MoveTables, setup reverse shard routing rules on workflow…
d1568f5 
… creation (#11415) (#11447)

* Testing....

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Update display representation of state for partially moved keyspaces

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Test improvements

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Cleanup shard routing rules on cancel/complete

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Cleanup intermediate changes

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix DryRun TrafficSwitcher and its tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Support concurrent partial movetables for N keyspaces

And other minor changes after self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Avoid unnecessary save + rebuild steps

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Add secondary ordering for shard routing rules on to_keyspace

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Minor changes after self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@ramsemune ramsemune mentioned this pull request Oct 6, 2022
Open
This was referenced Oct 25, 2022
Open
Open
@ramsemune ramsemune mentioned this pull request Nov 4, 2022
Open
@ramsemune ramsemune mentioned this pull request Nov 15, 2022
Open
@ramsemune ramsemune mentioned this pull request Nov 28, 2022
Open
@ramsemune ramsemune mentioned this pull request Dec 25, 2022
Open
@ramsemune ramsemune mentioned this pull request Mar 31, 2023
Open
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@snyk-bot snyk-bot mentioned this pull request May 22, 2023
Open
This was referenced May 22, 2023
Open
Open
This was referenced Jun 20, 2023
Open
Open
Open
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
@ramsemune ramsemune mentioned this pull request Oct 1, 2023
Open
@ramsemune ramsemune mentioned this pull request Nov 25, 2023
Open
@ramsemune ramsemune mentioned this pull request Dec 19, 2023
Open
@ramsemune ramsemune mentioned this pull request Jan 9, 2024
Open
This was referenced Feb 2, 2024
Open
Open
This was referenced Feb 11, 2024
Open
Open
@ramsemune ramsemune mentioned this pull request Mar 22, 2024
Open
This was referenced Apr 29, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@aquarapid aquarapid Awaiting requested review from aquarapid

Assignees

No one assigned

Labels

Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattlord @deepthi @rohit-nayak-ps