Migrates cmd/vtbench to pflags#11366
Merged
frouioui merged 4 commits intovitessio:mainfrom Sep 29, 2022
Merged
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
frouioui
commented
Sep 27, 2022
go/cmd/vtbench/vtbench.go
Outdated
Comment on lines
115
to
116
| logger := logutil.NewConsoleLogger() | ||
| flag.CommandLine.SetOutput(logutil.NewLoggerWriter(logger)) |
Member
Author
Contributor
There was a problem hiding this comment.
well, it depends on what you want 😅
if you want to keep the behavior, you want to something like:
servenv.OnParse(func(fs *pflag.FlagSet) {
fs.SetOutput(logutil.NewLoggerWriter(logger))
}
3 tasks
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
f135d07 to
9f46586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
cmd/vtbenchto use pflags as instructed in #10697.Related Issue(s)
package go/cmd/vtbench#11287Checklist
Deployment Notes