Skip to content

[vtexplain] Migrate to pflags#11364

Merged
systay merged 3 commits intovitessio:mainfrom
planetscale:systay/vtexplain-pflags
Sep 29, 2022
Merged

[vtexplain] Migrate to pflags#11364
systay merged 3 commits intovitessio:mainfrom
planetscale:systay/vtexplain-pflags

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Sep 27, 2022

Description

Switches vtexplain to use pflags according to #10697

Related Issue(s)

Fixes #11285

@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: CLI labels Sep 27, 2022
@systay systay requested a review from ajm188 as a code owner September 27, 2022 07:11
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 27, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good to me!

Copy link
Copy Markdown
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing, then merge merge merge!

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the systay/vtexplain-pflags branch from 60dd54c to dfefd9e Compare September 28, 2022 14:00
@systay systay merged commit 067cd8a into vitessio:main Sep 29, 2022
@systay systay deleted the systay/vtexplain-pflags branch September 29, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: CLI Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch flag definitions to be on pflag instead of flag in package go/cmd/vtexplain

4 participants