Change use_super_read_only default back to false#10448
Merged
mattlord merged 2 commits intovitessio:mainfrom Jun 6, 2022
Merged
Change use_super_read_only default back to false#10448mattlord merged 2 commits intovitessio:mainfrom
mattlord merged 2 commits intovitessio:mainfrom
Conversation
This is because when this flag is true you may not be able to restart a
replica/rdonly vttablet process. This is because:
1. The tablet has enabled super_read_only in its mysqld because it's
a replica tablet.
2. When a tablet starts up, it attempts to run some DDL statements as
the DBA user such as CREATE DATABASE IF NOT EXISTS _vt and that
will fail with an error because the mysqld has super_read_only
enabled.
3. So the tablet will not be able to come back up properly.
We really should be enabling super_read_only, both in the config file
and in the tablet via this flag, as without that we will in some
cases allow errant GTIDs to be generated which are then lying in wait
to cause later issues. We will enable it at both layers as part
of adding full super_read_only support to Vitess in (which is
targeted for v15):
vitessio#10363
Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
deepthi
approved these changes
Jun 6, 2022
Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
3 tasks
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we change the default for the vttablet
--use_super_read_onlyflag back to false (it was changed to true in v13 via #9312).We are doing this because when this flag is true you may not be able to restart a replica/rdonly vttablet process. This is because:
super_read_onlyin its mysqld because it's a replica tablet.CREATE DATABASE IF NOT EXISTS _vtand that will fail with an error because the mysqld hassuper_read_onlyenabled.We really should be enabling
super_read_only, both in the MySQL config file and in the tablet via this flag, as without that we will in some cases allow errant GTIDs to be generated which are then lying in wait to cause later issues. We will enable it at both layers as part of adding fullsuper_read_onlysupport to Vitess in #10363 (which is targeted for v15).Related Issue(s)
Checklist