Skip to content

Revert super_read_only config file changes#10366

Merged
mattlord merged 2 commits intovitessio:mainfrom
planetscale:revert_sro_cnf_change
May 25, 2022
Merged

Revert super_read_only config file changes#10366
mattlord merged 2 commits intovitessio:mainfrom
planetscale:revert_sro_cnf_change

Conversation

@mattlord
Copy link
Copy Markdown
Member

@mattlord mattlord commented May 24, 2022

Description

We intended to use super_read_only everywhere by default in #9312. To our surprise, everything worked and it was an easy change. But... it turned out this was because the config file changes didn't actually take effect because we forgot that we need to update the config file contents that are embedded in mysqlctl's rice box. 🙂

When that change was applied in mysqlctl by updating its rice box (using make embed_config) we saw a huge number of test failures as can be seen in: #10094.

We're instead going to revert the config file specific changes here and schedule work to properly add full super_read_only support to Vitess in: #10363.

After all of this the PR ensures that the embedded mysqlctl content is up-to-date with the repo contents and allows us to add a test for this in #10182.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests are not required
  • Documentation is not required

This ended up causing various failures when that change was applied
in mysqlctl by updating its rice box (make embed_config). You can see
this in: vitessio#10094

We're instead going to schedule work to add full super_read_only
support to Vitess in: vitessio#10363

Signed-off-by: Matt Lord <mattalord@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 24, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

This is a follow-up to vitessio#10295

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit 2cf3fb7 into vitessio:main May 25, 2022
@mattlord mattlord deleted the revert_sro_cnf_change branch May 25, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants