Revert super_read_only config file changes#10366
Merged
mattlord merged 2 commits intovitessio:mainfrom May 25, 2022
Merged
Conversation
This ended up causing various failures when that change was applied in mysqlctl by updating its rice box (make embed_config). You can see this in: vitessio#10094 We're instead going to schedule work to add full super_read_only support to Vitess in: vitessio#10363 Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
This is a follow-up to vitessio#10295 Signed-off-by: Matt Lord <mattalord@gmail.com>
deepthi
approved these changes
May 25, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We intended to use
super_read_onlyeverywhere by default in #9312. To our surprise, everything worked and it was an easy change. But... it turned out this was because the config file changes didn't actually take effect because we forgot that we need to update the config file contents that are embedded in mysqlctl's rice box. 🙂When that change was applied in mysqlctl by updating its rice box (using
make embed_config) we saw a huge number of test failures as can be seen in: #10094.We're instead going to revert the config file specific changes here and schedule work to properly add full
super_read_onlysupport to Vitess in: #10363.After all of this the PR ensures that the embedded
mysqlctlcontent is up-to-date with the repo contents and allows us to add a test for this in #10182.Related Issue(s)
Checklist