-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update to esbuild 0.14.14, with patched dist #6639
Conversation
I tested this more, and the patched dist looks good to me. The plugin is properly imported in cjs and esm contexts. The issue is also the same as when compiling with rollup. The only failing test is
This issue is gone when using @aleclarson I think this is pointing to an issue on |
Updated the react-emotion to use We could move forward with this PR (or the rollup based one #6329), so we unblock the release of Vite 2.8. If we do so, we shouldn't release @vitejs/plugin-react until the react-emotion test is properly fixed. |
I think I found the culprit |
Note this promise is an async import:
So, adding a |
Description
Implement an idea from @antfu, using esbuild 0.14.14 and adding the commonjs require hack after bundling instead of before it.
Additional context
This allows us to continue using esbuild to bundle plugin-vue and plugin-react, but I think there are new bugs surfacing because of the new esbuild version in plugin-react
esbuild 0.14.4 introduced a breaking change.
What is the purpose of this pull request?