Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade esbuild and migrate to rollup #6329

Closed
wants to merge 10 commits into from

Conversation

Niputi
Copy link
Contributor

@Niputi Niputi commented Dec 30, 2021

Description

for upgrading to latest esbuild.

from version 0.14.4 esbuild it's no longer possible to use the overwrite for cjs require('...')() usage hack to use named and default export

have tried migrating to rollup but getting [BABEL] /home/runner/work/vite/vite/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/react-switch/dist/react-switch.min.js: .default is not a valid Plugin property in react tests

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

import commonjs from '@rollup/plugin-commonjs'

/**
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this blank line

@Niputi
Copy link
Contributor Author

Niputi commented Jan 17, 2022

context on why it's a bad idea with default and named export are not good to mix - rollup/rollup#1961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants