Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): improve prompt message #3769

Merged
merged 2 commits into from
Jun 12, 2021
Merged

fix(create-app): improve prompt message #3769

merged 2 commits into from
Jun 12, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Description

Before

before

After

after

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Jun 11, 2021
View reviewed changes
Shinigami92
Shinigami92 suggested changes Jun 11, 2021
View reviewed changes
packages/create-app/index.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 11, 2021
@patak-dev patak-dev merged commit 9703bcd into vitejs:main Jun 12, 2021
@jamesgeorge007 jamesgeorge007 deleted the prompt-message branch June 12, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @patak-dev @Shinigami92