fix(create-app): improve prompt message (#3769)

vitejs · Jun 12, 2021 · 9703bcd · 9703bcd
1 parent d3e8bef
commit 9703bcd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/create-app/__tests__/cli.spec.ts b/packages/create-app/__tests__/cli.spec.ts
@@ -44,6 +44,11 @@ test('prompts for the framework if none supplied', () => {
   expect(stdout).toContain('Select a framework:')
 })
 
+test('prompts for the framework on not supplying a value for --template', () => {
+  const { stdout } = run([projectName, '--template'])
+  expect(stdout).toContain('Select a framework:')
+})
+
 test('prompts for the framework on supplying an invalid template', () => {
   const { stdout } = run([projectName, '--template', 'unknown'])
   expect(stdout).toContain(

diff --git a/packages/create-app/index.js b/packages/create-app/index.js
@@ -175,7 +175,7 @@ async function init() {
           type: template && TEMPLATES.includes(template) ? null : 'select',
           name: 'framework',
           message:
-            template && !TEMPLATES.includes(template)
+            typeof template === 'string' && !TEMPLATES.includes(template)
               ? `"${template}" isn't a valid template. Please choose from below: `
               : 'Select a framework:',
           initial: 0,