-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: migrate plugin-react-refresh
to plugin-react
#3588
Conversation
I added now the new label |
plugin-react-refresh
to plugin-react
Thanks @aleclarson for your work in that PR, it's something I'm really looking forward to :) What is the status of the works? |
@kjeske It should be ready for use. To get this merged, someone needs to setup some tests in Specifically, playground/react should be migrated to use |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getJSXNode
, getJSXName
, getJSXProps
and getJSXChildren
feels a bit to wide open 🤔
Maybe they can benefit from using generic arguments
It might be better to copy over the unit tests from here instead of trying to perfect the types. I don't expect much future development of |
Okay, so I'm glad that I just was bored yesterday 😄 |
What's missing now in this PR to be completed? |
@kjeske See the todos in the OP. Feel free to open a PR targeting this one if you decide to help out 😃 |
This reverts commit f9006ba.
This dependency is minified and commonjs, which will test the capabilities of the `restoreJSX` function.
Also: - check `jsxInject` inside configResolved - ensure all config values have reasonable defaults for Rollup compatibility
Co-authored-by: Shinigami <[email protected]>
287bd3e
to
bfd5a9a
Compare
See #3588 for full commit history Co-authored-by: Shinigami <[email protected]> Co-authored-by: Peng Xiao <[email protected]>
See #3588 for full commit history Co-authored-by: Shinigami <[email protected]> Co-authored-by: Peng Xiao <[email protected]>
See #3588 for full commit history Co-authored-by: Shinigami <[email protected]> Co-authored-by: Peng Xiao <[email protected]>
See vitejs#3588 for full commit history Co-authored-by: Shinigami <[email protected]> Co-authored-by: Peng Xiao <[email protected]>
See vitejs#3588 for full commit history Co-authored-by: Shinigami <[email protected]> Co-authored-by: Peng Xiao <[email protected]>
Description
Once this plugin is released,
@vitejs/plugin-react-refresh
should be deprecated.This plugin will do the following:
plugin-react-refresh
)vite-react-jsx
is also usedStatus
Almost ready to ship 🚢
Remaining questions
jsxRuntime: "automatic"
be the default?plugin-react/CHANGELOG.md
?Todo
./packages/playground
(in progress by @pengx17)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).