-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-react-refresh): support configure babel plugins #3319
Conversation
```js | ||
export default { | ||
plugins: [reactRefresh({ | ||
plugins: ['@emotion/babel-plugin'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins: ['@emotion/babel-plugin'] | |
babelPlugins: ['@emotion/babel-plugin'] |
Should we be more explicit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think plugins
is ok, like parserPlugins
. The users should be aware the react-refresh
is construct on babel.
reactRefresh({
parserPlugins: [
'classProperties',
'classPrivateProperties'
]
})
Thanks for the PR! How the process will follow from now with the review and merging? It's just waiting in the queue? Who prioritizes the PRs for reviewing and then merging? |
After the discussion with Evan, we planed to rename /cc @aleclarson would you like to take care of the renaming and migrate process? |
Close in favor of #3588 |
fix: #3276
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).