Skip to content

feat(config): import.meta.filename/dirname support#15888

Merged
bluwy merged 1 commit into
vitejs:mainfrom
sapphi-red:feat/config-import-meta-dirname-filename
Mar 12, 2024
Merged

feat(config): import.meta.filename/dirname support#15888
bluwy merged 1 commit into
vitejs:mainfrom
sapphi-red:feat/config-import-meta-dirname-filename

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

Similar to #15887 but for config files.

Should be limit this feature to Node 21.2+?

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 12, 2024
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title feat(config): import.meta.filename/import.meta.dirname support feat(config): import.meta.filename/dirname support Feb 12, 2024
Copy link
Copy Markdown
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the feature for all Node versions

@patak-cat patak-cat added this to the 5.2 milestone Feb 13, 2024
@bluwy bluwy merged commit 3efb1a1 into vitejs:main Mar 12, 2024
@sapphi-red sapphi-red deleted the feat/config-import-meta-dirname-filename branch March 14, 2024 06:03
@patak-cat
Copy link
Copy Markdown
Member

@Bravefriend82 stop sending these approvals and comments on merged PRs or you are going to be banned from all the github orgs you're interacting with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants