Skip to content

feat(ssr): import.meta.filename/dirname support#15887

Merged
bluwy merged 3 commits into
vitejs:mainfrom
sapphi-red:feat/ssr-import-meta-filename
Mar 12, 2024
Merged

feat(ssr): import.meta.filename/dirname support#15887
bluwy merged 3 commits into
vitejs:mainfrom
sapphi-red:feat/ssr-import-meta-filename

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

import.meta.dirname and import.meta.filename are supported in Node 21.2+. We already support this in the Vite Runtime API.

filename: isWindows ? toWindowsPath(filename) : filename,
dirname: isWindows ? toWindowsPath(dirname) : dirname,

It's still a release candidate. If there's a change in Node, I think we can change it in a minor.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels Feb 12, 2024
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-cat
patak-cat previously approved these changes Feb 13, 2024
@patak-cat patak-cat added this to the 5.2 milestone Feb 13, 2024
bluwy
bluwy previously approved these changes Feb 13, 2024
@bluwy bluwy dismissed stale reviews from patak-cat and themself via 2708fac March 12, 2024 14:02
@bluwy bluwy merged commit 74dc73a into vitejs:main Mar 12, 2024
@sapphi-red sapphi-red deleted the feat/ssr-import-meta-filename branch March 14, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants