Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGB color support #260

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Add RGB color support #260

merged 4 commits into from
Nov 20, 2024

Conversation

werneckpaiva
Copy link
Contributor

This change enables the the library to handle RGB color values. It seamlessly integrates with existing handlers, maintaining backward compatibility for those that don't utilize RGB functionality. It supports hue/saturation and color temperature (shades of white) formats used by Alexa.

@pvint
Copy link
Member

pvint commented Oct 10, 2024

This looks awesome @werneckpaiva !!
I've been meaning to get back to this for ages... but for some reason never came up with a good solution. Thanks so much!

I'll try to test over the next day or so, but I may get delayed, so if anyone else tests please let me know.

Paul

@werneckpaiva
Copy link
Contributor Author

Great Paul! I also found the PR from Spencer (#207), which is a bit outdated now, but it has some intersting ideas, specially when reporting the status back to Alexa. I will also try to create another PR adding it.

@pvint pvint self-assigned this Oct 27, 2024
@pvint
Copy link
Member

pvint commented Oct 29, 2024

@werneckpaiva Could I trouble you to change byte variables to char (or whatever makes sense) please? Just want to keep compatibility with ESP-IDF which doesn't use byte

@pvint
Copy link
Member

pvint commented Nov 20, 2024

I'll go ahead and merge this and I'll take care of the changes from byte after. Thank you again @werneckpaiva for this!

@pvint pvint closed this Nov 20, 2024
@pvint pvint reopened this Nov 20, 2024
@pvint pvint merged commit 8933085 into vintlabs:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants