Color-code stealth mode in the TMC2130 indicator #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a different color ("acid green") for stealth mode, so that we can
distinguish the driver state.
vintagepc
requested changes
Apr 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 89.16% 89.17%
=======================================
Files 140 140
Lines 6619 6622 +3
=======================================
+ Hits 5902 5905 +3
Misses 717 717
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a different color ("acid green") for stealth mode, so that we can distinguish the driver state.
Stuff you'd normally do "by ear" ;)
Behaviour/ Breaking changes
No change in code, just in visuals:
Have you tested the changes?
Lookin' good
Other
Linked issues:
Going to use this to debug the nasty "Delta_PSU" behavior...