Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming to use toPoint #6

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix naming to use toPoint #6

merged 2 commits into from
Aug 21, 2020

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Aug 21, 2020

Closes GH-5.

wooorm added 2 commits August 21, 2020 18:10
@wooorm
Update dev-dependencies
accf7a7
@wooorm
Fix naming to use toPoint
05518e5 
- `toPosition` is considered deprecated

Closes GH-5.
@wooorm wooorm added 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change 📚 area/docs This affects documentation 🗄 area/interface This affects the public interface 🙆 yes/confirmed This is confirmed and ready to be worked on labels Aug 21, 2020
@wooorm wooorm requested a review from ChristianMurphy August 21, 2020 16:19
@wooorm wooorm changed the title @wooorm Fix naming to use toPoint Fix naming to use toPoint Aug 21, 2020
@wooorm
Copy link
Member Author

wooorm commented Aug 21, 2020

lol, whoops about the title

@wooorm wooorm merged commit ef0ea9a into main Aug 21, 2020
@wooorm wooorm deleted the point branch August 21, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
📚 area/docs This affects documentation 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Position vs Point
2 participants
@wooorm @ChristianMurphy