Position vs Point

[muescha]

the readme is confusing.

the function expect an unist.Point instead of unist.Position

there should be this notation change for readme:

• change Position to Point

PS: i think the refactor the function name toPosition to toPoint would be harder

[wooorm]

Ah yeah, thanks. Reason is that we didn’t have a term to differentiate between the two when this project was created..

PR welcome to a) fix the docs, b) add a toPoint function and alias toPosition to it? Next major we could remove toPosition.

[muescha]

declare namespace vfileLocation {
  type Position = Pick<Point, 'line' | 'column'>

//...
toOffset: (position: Position) => Offset

any hint how this would be changed?

[ChristianMurphy]

For a) do nothing.
For b)

declare namespace vfileLocation {
  type Point = Pick<unist.Point, 'line' | 'column'>
  /** @deprecated */
  type Position = Point
  //...
    toOffset: (position: Point) => Offset

[wooorm]

@muescha What do you think, are you interesting and able to work on a PR?

[muescha]

it was out of my scope - i will give it a try