Repository navigation
[ckpt, ray, trainer] feat: add opt-in sub-second fault tolerance with dynamic NCCL re-rendezvous and in-memory failover - #7910
Open
sunnylovestiramisu wants to merge 1 commit into
Conversation
…ynamic NCCL re-rendezvous and in-memory failover
sunnylovestiramisu
requested review from
PeterSH6,
eric-haibin-lin,
tongyx361,
vermouth1992,
wuxibin89 and
zw0610
as code owners
September 17, 2026 22:40
6 of 8 tasks
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an opt-in fault tolerance architecture for disaggregated RL training (Trainer & Rollout separated across GPU nodes) that prevents pipeline collapse and long restarts when GPU workers or nodes abruptly fail (e.g., hard process crashes, CUDA uncorrectable ECC errors, or cloud provider maintenance notices like rack switch events).
Currently, VeRL's NCCL checkpoint engine requires static communicators; a worker crash causes socket timeout and terminates the distributed Ray job. With this PR, when fault_tolerance.enable=True, VeRL:
Default Behavior: Gated behind fault_tolerance.enable=False (default), ensuring 100% backward compatibility and zero overhead for standard runs.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
Validated on a 3-node Google Cloud A3 HighGPU cluster (24x NVIDIA H100 80GB GPUs, GPUDirect-TCPX) running disaggregated RL training with Qwen/Qwen2.5-0.5B (942.3 MB parameters in VRAM):
Test Logs
API and Usage Example
Standard execution remains completely untouched:
Design & Code Changes
Detailed File Changes:
Added re_rendezvous(...): Safely destroys stale NCCL communicator and rejoins a new versioned group (group_name_v{version}) on dynamic port.
Added recover_weights_from_rollout(): Enables promoted trainer to pull weights directly from rollout VRAM over NCCL (src=num_senders).
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.