[recipe] refactor: refactor ray trainer for separate recipe use. (fully async / one step off) by ArronHZG · Pull Request #5184 · verl-project/verl

ArronHZG · 2026-02-03T06:11:48Z

What does this PR do?

Add a new Ray Trainer class to facilitate reusing the core logic.
And fix fully async / one step off CI.
Currently, our parameter synchronization logic is still in a broken state.

CI break in #4280

Checklist Before Starting

Search for similar PRs. Paste at least one query link here: ...
Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
- {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
- If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
- {type} is in feat, fix, refactor, chore, test
- If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
- Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Read the Contribute Guide.
Apply pre-commit checks: pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always
Add / Update the documentation.
Add unit or end-to-end test(s) to the CI workflow to cover all the code. If not feasible, explain why: ...
Once your PR is ready for CI, send a message in the ci-request channel in the verl Slack workspace. (If not accessible, please try the Feishu group (飞书群).)
If your PR is related to the recipe submodule, please also update the reference to the submodule commit via git submodule update --remote or cd recipe && git pull origin main.

Shangwei-Li · 2026-02-05T12:41:41Z

verl/experimental/fully_async_policy/fully_async_trainer.py

+        """
+        如果 algorithm.rollout_correction.bypass_mode 为 False，则计算 old_log_prob
+        """
+        # If local_triger_step == 1, load the training engine's parameters to the CPU


'local_triger_step' is a typo.

Shangwei-Li · 2026-02-05T12:53:32Z

verl/experimental/fully_async_policy/fully_async_main.py

+            trainer_future = executor.submit(self._create_trainer, config)
+            # Wait for both to complete
+            rollouter_future.result()
+            trainer_future.result()


Suggesting keep _create_rollouter and _create_trainer sequential until [pr 4792](#4792) is merged, considering standalone launching mode does not promise bundled allocation.

Ok, We can make revisions after it's fully tested and running.

Shangwei-Li · 2026-02-05T13:58:21Z

verl/experimental/fully_async_policy/fully_async_trainer.py

+        if self.local_trigger_step == 1:
+            self.actor_rollout_wg.save_model_to_cpu(1)
+            old_log_prob, old_log_prob_mfu = super()._compute_old_log_prob(batch)
+        elif self.local_trigger_step is not None:


Is this still necessary? The default value of local_trigger_step is 1 now and at no case should it be None.

get it, i will change it.

if bypass_recomputing_logprobs: ... else: # Recompute old_log_probs with marked_timer("old_log_prob", timing_raw, color="blue"): old_log_prob, old_log_prob_mfu = self._compute_old_log_prob(batch)

_compute_old_log_prob will use in not bypass_recomputing_logprobs mode.

…ly async / one step off) (verl-project#5184) ### What does this PR do? * Add a new Ray Trainer class to facilitate reusing the core logic. * And fix fully async / one step off CI. * Currently, our parameter synchronization logic is still in a broken state. CI break in verl-project#4280 ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [x] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [ ] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.

ArronHZG added 2 commits February 3, 2026 14:09

refactor SeparateRayPPOTrainer

fcfb19d

FullyAsyncRollouter

bca02d4

ArronHZG changed the title ~~[recipe] refactor: refactor ray trainer for separate recipe use. (fully asyn / one step off)~~ [recipe] refactor: refactor ray trainer for separate recipe use. (fully async / one step off) Feb 4, 2026

ArronHZG added 8 commits February 4, 2026 14:34

_fit_update_weights

be6e6fd

Merge branch 'main' into refactor_fully_async_ray_trainer

4d00f75

fix one step off ci

b740472

fix one step off ci file

8678044

fix fully async ci file

fb681ce

fix fully async ci, use vllm rollout

39203e0

merga main

ac90271

ruff format

2de20a2

ArronHZG marked this pull request as ready for review February 5, 2026 12:29

ArronHZG requested review from ISEEKYAN, PeterSH6, chenhaiq, eric-haibin-lin, tongyx361 and vermouth1992 as code owners February 5, 2026 12:29

update annotation

4813956

Shangwei-Li reviewed Feb 5, 2026

View reviewed changes

update

18b8475

ArronHZG requested a review from wuxibin89 February 6, 2026 06:15

mv separation ray trainer

199279e

wuxibin89 approved these changes Feb 6, 2026

View reviewed changes

ArronHZG merged commit 32f2d3d into verl-project:main Feb 6, 2026
100 of 126 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[recipe] refactor: refactor ray trainer for separate recipe use. (fully async / one step off)#5184

[recipe] refactor: refactor ray trainer for separate recipe use. (fully async / one step off)#5184
ArronHZG merged 13 commits intoverl-project:mainfrom
meituan-search:refactor_fully_async_ray_trainer

ArronHZG commented Feb 3, 2026 •

edited

Loading

Uh oh!

Shangwei-Li Feb 5, 2026

Uh oh!

Shangwei-Li Feb 5, 2026

Uh oh!

ArronHZG Feb 6, 2026

Uh oh!

Shangwei-Li Feb 5, 2026

Uh oh!

ArronHZG Feb 6, 2026

Uh oh!

ArronHZG Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

ArronHZG commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist Before Starting

Test

API and Usage Example

Design & Code Changes

Checklist Before Submitting

Uh oh!

Shangwei-Li Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Shangwei-Li Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ArronHZG Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Shangwei-Li Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ArronHZG Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

ArronHZG Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ArronHZG commented Feb 3, 2026 •

edited

Loading