Skip to content

Comments

[rollout,vllm] feat: revert default value of max_num_seqs#5139

Merged
vermouth1992 merged 1 commit intoverl-project:mainfrom
RobotGF:robotgf/revert_max_num_seqs
Jan 31, 2026
Merged

[rollout,vllm] feat: revert default value of max_num_seqs#5139
vermouth1992 merged 1 commit intoverl-project:mainfrom
RobotGF:robotgf/revert_max_num_seqs

Conversation

@RobotGF
Copy link
Contributor

@RobotGF RobotGF commented Jan 30, 2026

What does this PR do?

#4280
Revert the default value of vllm max_num_seqs which may effect the throughput

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@RobotGF RobotGF force-pushed the robotgf/revert_max_num_seqs branch from 3b117f6 to c0a07db Compare January 30, 2026 16:12
@vermouth1992 vermouth1992 merged commit e2ae919 into verl-project:main Jan 31, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants