[megatron] chore: clean legacy code path part 2, clean legacy CI#4529
[megatron] chore: clean legacy code path part 2, clean legacy CI#4529wuxibin89 merged 6 commits intoverl-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request focuses on cleaning up legacy Megatron code paths and making mbridge the default, which is a positive step towards simplifying the codebase. The changes across documentation, shell scripts, and Python code are largely consistent with this goal. However, I've identified a critical issue in verl/models/mcore/registry.py where the logic for identifying Vision Language Models (VLMs) is flawed. This bug would cause VLMs to use an incorrect forward pass, breaking their functionality. I've provided suggestions to correct this. Please address these critical issues to ensure the new implementation works as expected for all model types.
| Get the forward function for given model architecture. | ||
| """ | ||
| assert len(hf_config.architectures) == 1, "Only one architecture is supported for now" | ||
| if hf_config.architectures[0] in SupportedVLM: |
There was a problem hiding this comment.
The check hf_config.architectures[0] in SupportedVLM is incorrect. SupportedVLM is an Enum class, and this check will always evaluate to False because hf_config.architectures[0] is a string, not an enum member. This will cause Vision Language Models (VLMs) to be incorrectly treated as standard language models, leading to the use of the wrong forward function.
To fix this, you should check against the values of the enum members.
| if hf_config.architectures[0] in SupportedVLM: | |
| if hf_config.architectures[0] in {item.value for item in SupportedVLM}: |
| Get the forward function for given model architecture. | ||
| """ | ||
| assert len(hf_config.architectures) == 1, "Only one architecture is supported for now" | ||
| if hf_config.architectures[0] in SupportedVLM: |
There was a problem hiding this comment.
Similar to the previous comment, the check hf_config.architectures[0] in SupportedVLM is incorrect and will always evaluate to False. This will cause Vision Language Models (VLMs) to use the wrong fused forward function, as they will be misidentified as standard language models.
To fix this, you should check against the values of the enum members.
| if hf_config.architectures[0] in SupportedVLM: | |
| if hf_config.architectures[0] in {item.value for item in SupportedVLM}: |
…l-project#4529) ### What does this PR do? this is one of a series PRs to clean the legacy megatron code path and make bridge the default path for megatron. verl-project#4496 This PR make clean CIs, including qwen2.5vl megatron, model merger, config converter ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
…l-project#4529) ### What does this PR do? this is one of a series PRs to clean the legacy megatron code path and make bridge the default path for megatron. verl-project#4496 This PR make clean CIs, including qwen2.5vl megatron, model merger, config converter ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
What does this PR do?
this is one of a series PRs to clean the legacy megatron code path and make bridge the default path for megatron. #4496
This PR make clean CIs, including qwen2.5vl megatron, model merger, config converter
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)