Skip to content

[rollout] fix: error in sgyang async mode #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhaochenyang20 merged 3 commits into from
Jun 20, 2025
Merged

[rollout] fix: error in sgyang async mode #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b16a462
[rollout] fix error in sgyang async mode
chenhaiq Jun 19, 2025
68197a4
enable raw chat in async mode
chenhaiq Jun 19, 2025
d1789ae
add os env for vllm async
chenhaiq Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/e2e_ppo_trainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,16 @@ jobs:
run: |
ray stop --force
ENGINE=sglang bash tests/special_e2e/ppo_trainer/run_function_reward.sh
- name: Running GSM8K E2E training tests on sglang async
run: |
ray stop --force
ENGINE=sglang ROLLOUT_MODE=async bash tests/special_e2e/ppo_trainer/run_function_reward.sh
- name: Running GSM8K E2E training tests on vllm async
run: |
ray stop --force
export VLLM_USE_V1=1
ray start --head
ENGINE=vllm ROLLOUT_MODE=async bash tests/special_e2e/ppo_trainer/run_function_reward.sh

e2e_ppo_trainer_sglang_multiturn_with_tool:
runs-on: [L20x8]
Expand Down
7 changes: 7 additions & 0 deletions tests/special_e2e/ppo_trainer/run_function_reward.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ MAX_RESPONSE_LEN=${MAX_RESPONSE_LEN:-512}

ENGINE=${ENGINE:-vllm}
ROLLOUT_MODE=${ROLLOUT_MODE:-sync}

RETURN_RAW_CHAT="False"
if [ "$ROLLOUT_MODE" = "async" ]; then
RETURN_RAW_CHAT="True"
fi

GPU_MEMORY_UTILIZATION=${GPU_MEMORY_UTILIZATION:-0.8}
ACTOR_FSDP_PARAM_OFFLOAD=${ACTOR_FSDP_PARAM_OFFLOAD:-False}
ACTOR_FSDP_OPTIMIZER_OFFLOAD=${ACTOR_FSDP_OPTIMIZER_OFFLOAD:-False}
Expand Down Expand Up @@ -84,6 +90,7 @@ python3 -m verl.trainer.main_ppo \
data.train_batch_size="${train_prompt_bsz}" \
data.max_prompt_length="${MAX_PROMPT_LEN}" \
data.max_response_length="${MAX_RESPONSE_LEN}" \
data.return_raw_chat=${RETURN_RAW_CHAT} \
actor_rollout_ref.model.path="${MODEL_PATH}" \
actor_rollout_ref.model.use_shm=${USE_SHM} \
actor_rollout_ref.model.lora_rank=${LORA_RANK} \
Expand Down
5 changes: 2 additions & 3 deletions verl/workers/rollout/sglang_rollout/async_sglang_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@
class AsyncSglangServer(AsyncServerBase):
def __init__(self, config: DictConfig, dp_size: int, dp_rank: int, wg_prefix: str):
super().__init__()
self.config = config
rollout_config = config.get("rollout", {})
self._tp_size = rollout_config.get("tensor_model_parallel_size", 1)
self.config = config.actor_rollout_ref
self._tp_size = self.config.rollout.get("tensor_model_parallel_size", 1)
self._dp_size = dp_size
self._dp_rank = dp_rank
self.wg_prefix = wg_prefix
Expand Down
6 changes: 5 additions & 1 deletion verl/workers/rollout/sglang_rollout/sglang_rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ async def chat_completion(self, json_request):
request_id=str(uuid4()),
state=AsyncRolloutRequestStateEnum.PENDING,
messages=[Message.model_validate(msg) for msg in json_request["messages"]],
tools=_tool_schemas,
tool_schemas=_tool_schemas,
tools_kwargs=_tools_kwargs,
input_ids=_input_ids,
prompt_ids=_input_ids,
Expand All @@ -1099,8 +1099,12 @@ async def chat_completion(self, json_request):
prompt_loss_mask=[0] * len(_input_ids),
response_loss_mask=[],
reward_scores={},
max_prompt_len=self.config.prompt_length,
max_response_len=self.config.response_length,
max_model_len=min(self.config.max_model_len, self.config.prompt_length + self.config.response_length),
use_inference_chat_template=self.config.multi_turn.use_inference_chat_template,
enable_tokenization_sanity_check=self.config.multi_turn.enable_tokenization_sanity_check,
tokenizer=self.tokenizer,
)

# json_request already contains sampling_params
Expand Down
Loading