[rollout] fix: fix async llm config passing#1933
Merged
vermouth1992 merged 1 commit intoverl-project:mainfrom Jun 10, 2025
Merged
[rollout] fix: fix async llm config passing#1933vermouth1992 merged 1 commit intoverl-project:mainfrom
vermouth1992 merged 1 commit intoverl-project:mainfrom
Conversation
vermouth1992
approved these changes
Jun 10, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 10, 2025
### Checklist Before Starting - [x] Searched for similar PR(s). - [x] Checked PR Title format - [ ] In format of: [modules] type: Title - [ ] modules are in `fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt` - [ ] type is in `feat, fix, doc, refactor, chore` - [ ] can involve multiple modules, seperated by `,` or space, like `[megatron, fsdp] feat: xxx` ### What does this PR do? Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111 Also, move the sandbox test another folder to mirror source code folder structure. ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc. ### Additional Info. - **Issue Number**: Fixes issue # or discussion # if any. - **Training**: [Note which backend this PR will affect: FSDP, Megatron, both, or none] - **Inference**: [Note which backend this PR will affect: vLLM, SGLang, both, or none] ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [ ] Rely on existing unit tests on CI that covers the code path.
chenhaiq
added a commit
to chenhaiq/verl
that referenced
this pull request
Jun 19, 2025
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
zhaochenyang20
pushed a commit
that referenced
this pull request
Jun 20, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 23, 2025
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
Tyizhanshen
pushed a commit
to HyperdriveHustle/verl
that referenced
this pull request
Jul 1, 2025
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
### Checklist Before Starting - [x] Searched for similar PR(s). - [x] Checked PR Title format - [ ] In format of: [modules] type: Title - [ ] modules are in `fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt` - [ ] type is in `feat, fix, doc, refactor, chore` - [ ] can involve multiple modules, seperated by `,` or space, like `[megatron, fsdp] feat: xxx` ### What does this PR do? Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111 Also, move the sandbox test another folder to mirror source code folder structure. ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc. ### Additional Info. - **Issue Number**: Fixes issue # or discussion # if any. - **Training**: [Note which backend this PR will affect: FSDP, Megatron, both, or none] - **Inference**: [Note which backend this PR will affect: vLLM, SGLang, both, or none] ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [ ] Rely on existing unit tests on CI that covers the code path.
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
### Checklist Before Starting - [x] Searched for similar PR(s). - [x] Checked PR Title format - [ ] In format of: [modules] type: Title - [ ] modules are in `fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt` - [ ] type is in `feat, fix, doc, refactor, chore` - [ ] can involve multiple modules, seperated by `,` or space, like `[megatron, fsdp] feat: xxx` ### What does this PR do? Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111 Also, move the sandbox test another folder to mirror source code folder structure. ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc. ### Additional Info. - **Issue Number**: Fixes issue # or discussion # if any. - **Training**: [Note which backend this PR will affect: FSDP, Megatron, both, or none] - **Inference**: [Note which backend this PR will affect: vLLM, SGLang, both, or none] ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [ ] Rely on existing unit tests on CI that covers the code path.
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
paolo328
added a commit
to paolo328/Verl
that referenced
this pull request
Nov 27, 2025
Fixed regression from: - verl-project/verl#1668 - verl-project/verl#1933 Added e2e test for both sglang and vllm async mode test
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
### Checklist Before Starting - [x] Searched for similar PR(s). - [x] Checked PR Title format - [ ] In format of: [modules] type: Title - [ ] modules are in `fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt` - [ ] type is in `feat, fix, doc, refactor, chore` - [ ] can involve multiple modules, seperated by `,` or space, like `[megatron, fsdp] feat: xxx` ### What does this PR do? Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111 Also, move the sandbox test another folder to mirror source code folder structure. ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc. ### Additional Info. - **Issue Number**: Fixes issue # or discussion # if any. - **Training**: [Note which backend this PR will affect: FSDP, Megatron, both, or none] - **Inference**: [Note which backend this PR will affect: vLLM, SGLang, both, or none] ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [ ] Rely on existing unit tests on CI that covers the code path.
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
### Checklist Before Starting - [x] Searched for similar PR(s). - [x] Checked PR Title format - [ ] In format of: [modules] type: Title - [ ] modules are in `fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt` - [ ] type is in `feat, fix, doc, refactor, chore` - [ ] can involve multiple modules, seperated by `,` or space, like `[megatron, fsdp] feat: xxx` ### What does this PR do? Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111 Also, move the sandbox test another folder to mirror source code folder structure. ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc. ### Additional Info. - **Issue Number**: Fixes issue # or discussion # if any. - **Training**: [Note which backend this PR will affect: FSDP, Megatron, both, or none] - **Inference**: [Note which backend this PR will affect: vLLM, SGLang, both, or none] ### Checklist Before Submitting - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [ ] Rely on existing unit tests on CI that covers the code path.
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
Fixed regression from: - verl-project#1668 - verl-project#1933 Added e2e test for both sglang and vllm async mode test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
fsdp, megatron, sglang, vllm, rollout, trainer, tests, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckptfeat, fix, doc, refactor, chore,or space, like[megatron, fsdp] feat: xxxWhat does this PR do?
Here we should pass full config instead of the sub config. Consumed here: https://github.com/volcengine/verl/blob/main/verl/workers/rollout/async_server.py#L111
Also, move the sandbox test another folder to mirror source code folder structure.
Test
Additional Info.
Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.